Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): respect disable modulepreload #12111

Merged
merged 1 commit into from
Feb 19, 2023
Merged

fix(html): respect disable modulepreload #12111

merged 1 commit into from
Feb 19, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 19, 2023

Description

fix #11889

Don't inject modulepreload links in html when build.moduePreload: false

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 19, 2023
@patak-dev patak-dev merged commit 6c50119 into main Feb 19, 2023
@patak-dev patak-dev deleted the fix-module-preload-html branch February 19, 2023 20:21
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
fix(html): respect disable modulepreload (vitejs#12111)
11eb8c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.modulePreload: false is not working as documented
2 participants
@bluwy @patak-dev